Add _meta field to ilm policy #73515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
external-contributor
|
@dakrone, can you help to take a look at this PR? |
jrodewig
added
:Data Management/ILM+SLM
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
dakrone
requested changes
May 28, 2021
There was a problem hiding this comment.
Thanks for working on this @gaobinlong! I left a couple of comments, we need to add BWC version checks for the serialization
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/LifecyclePolicy.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/LifecyclePolicy.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine ok to test |
|
@dakrone, thanks for your review, I have added some BWC code and all checks have passed yet. |
|
@elasticmachine test this please |
dakrone
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
LGTM, thanks for adding this @gaobinlong! I'll merge this and work on backporting it.
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Jun 1, 2021
Relates to elastic#70755. The main changes of this PR are: Add an optional _meta field to ILM policy. Add some test code about the change. Update the doc of Create or update lifecycle policy API.
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Jun 1, 2021
This commit disables BWC tests until the PRs adding `_meta` to ILM policies can be backported and version constants added. Relates: elastic#73515, elastic#73624
dakrone
added a commit
that referenced
this pull request
Jun 1, 2021
dakrone
added a commit
that referenced
this pull request
Jun 1, 2021
Co-authored-by: bellengao <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #70755.
The main changes of this PR are:
_metafield to ILM policy.Create or update lifecycle policy API.