Throw an exception if Composite formats an after key it can't parse #73446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine update branch |
…eon/elasticsearch into composite-unparsable-after-key
|
I managed to get git into some awful state trying to merge my other DocValueFormat work into this. Will be easier to just open a fresh PR for this, which I will do shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This change will cause Composite to fail the query if the formatting settings cause it to generate an after key that it then cannot parse back to the correct value. There is a lot of janky type code in this right now, and I'm not sure we actually want to let that into production, but it'll be easier to talk about if we can look at some code.
Relates to #72556