Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print full JVM implementation version at start of build #73439

Merged
merged 1 commit into from
May 27, 2021

Conversation

mark-vieira
Copy link
Contributor

Back when we migrated our JDK detection logic to rely on the new Gradle JavaInstallation APIs we lost some fidelity in our reporting. We currently only report the major JDK version in the start of build banner. Ex:

=======================================
Elasticsearch Build Hamster says Hello!
  Gradle Version        : 7.0.2
  OS Info               : Linux 5.4.0-73-generic (amd64)
  JDK Version           : 16 (Oracle)
  JAVA_HOME             : /home/mark/.sdkman/candidates/java/16.0.1-open
  Random Testing Seed   : F65C14106572CEE0
  In FIPS 140 mode      : false
=======================================

At some point an internal API (yeah, I know) was added to get the full implementation version. We can now provide output like so:

=======================================
Elasticsearch Build Hamster says Hello!
  Gradle Version        : 7.0.2
  OS Info               : Linux 5.4.0-73-generic (amd64)
  JDK Version           : 16.0.1 (Oracle)
  JAVA_HOME             : /home/mark/.sdkman/candidates/java/16.0.1-open
  Random Testing Seed   : EA5CADE363C739DC
  In FIPS 140 mode      : false
=======================================

We've recently run into a number of issues where changes in JDK patch releases have caused test failures. Having full runtime JVM version included in the build output is helpful diagnostic data.

@mark-vieira mark-vieira added >non-issue :Delivery/Build Build or test infrastructure v8.0.0 labels May 26, 2021
@mark-vieira mark-vieira requested a review from breskeby May 26, 2021 20:50
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label May 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@mark-vieira mark-vieira merged commit ef2b231 into elastic:master May 27, 2021
@mark-vieira mark-vieira deleted the gradle_jdk_build_details branch May 27, 2021 15:14
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request May 27, 2021
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request May 27, 2021
limingnihao added a commit to limingnihao/elasticsearch that referenced this pull request May 28, 2021
* master: (1643 commits)
  Make DataStreamsSnapshotsIT resilient to failures because of local time. (elastic#73516)
  Upgrade netty to 4.1.63 (elastic#73011)
  [DOCS] Create a new page for dissect content in scripting docs (elastic#73437)
  Deprecate freeze index API (elastic#72618)
  [DOCS] Remove 'closed data stream' reference
  [DOCS] Update alias references (elastic#73427)
  [DOCS]  Create a new page for grok content in scripting docs (elastic#73118)
  Remove dependency on azure shadowjar since it's no longer required
  [DOCS] Update backport policy for known issues (elastic#73489)
  Shadowed dependencies should be hidden from pom dependencies (elastic#73467)
  Disable transitive dependencies when resolving bwc JDBC driver artifact (elastic#73448)
  Print full JVM implementation version at start of build (elastic#73439)
  [DOCS] Update snapshot/restore for data stream aliases (elastic#73438)
  Upgrade Azure SDK and Jackson (elastic#72833) (elastic#72995)
  [DOCS] Fix typo (elastic#73337) (elastic#73474)
  [DOCS] Fix typo (elastic#73444) (elastic#73472)
  [DOCS] Update alias security for data stream aliases (elastic#73436)
  Fix Bug with Concurrent Snapshot and Index Delete (elastic#73456)
  [DOCS] Move common scripting use cases up a level (elastic#73445)
  Add more validation for data stream aliases. (elastic#73416)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v7.13.1 v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants