-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify cancelled tasks in list tasks API #72931
Identify cancelled tasks in list tasks API #72931
Conversation
This commit adds a `cancelled` flag to each cancellable task in the response to the list tasks API, allowing users to see that a task has been properly cancelled and will complete as soon as possible. Closes elastic#72907
Pinging @elastic/es-distributed (Team:Distributed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks David!
@@ -243,6 +244,13 @@ nodes `nodeId1` and `nodeId2`. | |||
POST _tasks/_cancel?nodes=nodeId1,nodeId2&actions=*reindex | |||
-------------------------------------------------- | |||
|
|||
A task may continue to run for some time after it has been cancelled because it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is the kind of small changes that makes everyone's life easier 👍
Adjusts wire-compat and re-enables BWC tests
Thanks both! |
This commit adds a `cancelled` flag to each cancellable task in the response to the list tasks API, allowing users to see that a task has been properly cancelled and will complete as soon as possible. Closes #72907
This commit adds a
cancelled
flag to each cancellable task in theresponse to the list tasks API, allowing users to see that a task has
been properly cancelled and will complete as soon as possible.
Closes #72907