Script: Mangle user function names #72892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepend `&` to user function names. In future changes user functions will switch from being static methods to member methods. The mangled user function names will prohibit users from overriden other script methods. Refs: elastic#69742
stu-elastic
added
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
May 10, 2021
Prepend `&` to user function names. In future changes user functions will switch from being static methods to member methods. The mangled user function names will prohibit users from overriden other script methods. Refs: elastic#69742 Backport: f6bf99c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepend
&to user function names. In future changes userfunctions will switch from being static methods to member methods.
The mangled user function names will prohibit users from overriden
other script methods.
Refs: #69742