Fix privileges for predefined roles #72061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#71904 we added two new predefined roles, editor and viewer in elasticsearch. This change adds a missing application privilege to these roles. This is only needed in 7.x as the behavior has changed in Kibana, starting 8.0 and this extra privilege is not necessary.
jkakavas
added
>non-issue
:Security/Authorization
|
Pinging @elastic/es-security (Team:Security) |
bytebilly
requested changes
Apr 22, 2021
| .privileges("read").build() }, | ||
| .privileges("read").build(), | ||
| RoleDescriptor.ApplicationResourcePrivileges.builder() | ||
| .application("kibana-.*") |
There was a problem hiding this comment.
Suggested change
| .application("kibana-.*") | |
| .application("kibana-*") |
I think this is the right syntax, given the comment in #71710 (comment) and a chat I had with @legrego
I'll leave to Larry to comment futher.
There was a problem hiding this comment.
You're probably right, let's wait for @legrego to verify
There was a problem hiding this comment.
@jkakavas, @bytebilly's suggestion is the correct syntax: There should not be a . in the application name for "reserved" privileges
| .privileges("all").build() }, | ||
| .privileges("all").build(), | ||
| RoleDescriptor.ApplicationResourcePrivileges.builder() | ||
| .application("kibana-.*") |
There was a problem hiding this comment.
Suggested change
| .application("kibana-.*") | |
| .application("kibana-*") |
I think this is the right syntax, given the comment in #71710 (comment) and a chat I had with @legrego
I'll leave to Larry to comment futher.
|
@elasticmachine update branch |
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Apr 23, 2021
In elastic#71904 we added two new predefined roles, editor and viewer in elasticsearch. This change adds a missing application privilege to these roles. This is only needed in 7.x as the behavior has changed in Kibana, starting 8.0 and this extra privilege is not necessary.
jkakavas
added a commit
that referenced
this pull request
Apr 23, 2021
In #71904 we added two new predefined roles, editor and viewer in elasticsearch. This change adds a missing application privilege to these roles. This is only needed in 7.x as the behavior has changed in Kibana, starting 8.0 and this extra privilege is not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #71904 we added two new predefined roles, editor and viewer in
elasticsearch. This change adds a missing application privilege to
these roles. This is only needed in 7.x as the behavior has changed
in Kibana, starting 8.0 and this extra privilege is not necessary.
Marking as non-issue as this is not yet released.