Bump minimum compiler version to Java 16 #71989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
Gonna need to get https://github.com/elastic/infra/pull/28480 merged in first since we only have Java 16 on our Linux workers. |
pugnascotia
approved these changes
Apr 21, 2021
|
@elasticmachine update branch |
|
I think this might also be blocked on the release of 6.2.0 of the Gradle shadow plugin. |
|
Windows builds are failing due to the lack of JDK 16 on the agents. The ansible playbooks have been updated but there's another issue blocking the new images being build. Have an issue open with infra for this. |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
…a-16 # Conflicts: # gradle.properties
…to minimum-compile-java-16
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
May 25, 2021
# Conflicts: # .ci/java-versions.properties
mark-vieira
added a commit
that referenced
this pull request
May 26, 2021
This reverts commit bc9521e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've upgrade to Gradle 7.0 we can bump the minimum compiler version to Java 16 to be in line with the bundled JDK and put us back on a supported version (Java 15 is EOL).
I've also relaxed the JDK requirement for builds run via IntelliJ. The idea here being that the JDK is set by the build, but the build in turn requires a certain JDK. To avoid this awkward chicken/egg situation we just ignore the requirement when running in the IDE. We still fail on the CLI in these scenarios though.