Reject multiple data paths on frozen capable nodes #71896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nodes with a frozen cache no longer supports multiple data paths. This simplifies cache sizing and avoids the need to support multiple cache files. Relates elastic#71844
henningandersen
added
>enhancement
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Apr 20, 2021
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Apr 20, 2021
ywelsch
reviewed
Apr 20, 2021
| final List<String> dataPaths = (List<String>) settings.get(Environment.PATH_DATA_SETTING); | ||
| if (dataPaths.size() > 1) { | ||
| throw new SettingsException( | ||
| "setting [{}={}] is not permitted on nodes with multiple data paths [{}]", |
There was a problem hiding this comment.
How does this interact with the other PR (default frozen cache size) when you have multiple data paths defined and a dedicated frozen node defined, but have not explicitly configured a cache size?
There was a problem hiding this comment.
It is my intention to make that case fail once I merge the two together.
tlrx
approved these changes
Apr 20, 2021
| } | ||
| } | ||
| } | ||
| assertTrue("no shard folder found", shardFolderFound); |
There was a problem hiding this comment.
Maybe indicate the name of the index in the error?
There was a problem hiding this comment.
Added in 3163266
| final ShardPath shardPath = ShardPath.loadShardPath(logger, service, shardId, customDataPath); | ||
| if (shardPath != null && Files.exists(shardPath.getDataPath())) { | ||
| shardFolderFound = true; | ||
| assertEquals(snapshotDirectory, Files.notExists(shardPath.resolveIndex())); |
There was a problem hiding this comment.
I guess we could determine snapshotDirectory from the index settings?
There was a problem hiding this comment.
I simply moved this method from SearchableSnapshotsIntegTests so will defer improving this to a follow-up.
…ct_multiple_data_paths
…ct_multiple_data_paths
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Apr 20, 2021
Nodes with a frozen cache no longer supports multiple data paths. This simplifies cache sizing and avoids the need to support multiple cache files. Relates elastic#71844
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Apr 20, 2021
PartiallyCachedShardAllocationIntegTests does not support multiple data paths, since it uses frozen cache, fixed. Caused by elastic#71896
henningandersen
added a commit
that referenced
this pull request
Apr 20, 2021
PartiallyCachedShardAllocationIntegTests does not support multiple data paths, since it uses frozen cache, fixed. Caused by #71896
henningandersen
added a commit
that referenced
this pull request
Apr 20, 2021
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Apr 22, 2021
henningandersen
added a commit
that referenced
this pull request
May 5, 2021
henningandersen
added a commit
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes with a frozen cache no longer supports multiple data paths. This
simplifies cache sizing and avoids the need to support multiple cache
files.
Relates #71844 (which also contains the single line documentation on this).