CORE: Validate list values for settings #71276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings value could be a list. This should only happen if the underlying setting type is a list setting type. * Validation has been added that * when we get a setting value which is list, setting is also a list setting * when we get a value for a list setting, underlying value is also a list * Closes #33135
elasticsearchmachine
added
the
external-contributor
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
ok to test |
|
@elasticmachine update branch |
pgomulka
suggested changes
May 12, 2021
There was a problem hiding this comment.
looks good, thanks!
can you add the testcase for happy path and fix the failing test?
You might need to change the exception message and remove the if condition that throws Environment
String rawDataPath = PATH_DATA_SETTING.get(settings);
if (rawDataPath.startsWith("[")) {
| IllegalArgumentException e = expectThrows(IllegalArgumentException.class, () -> stringSetting.get(settings)); | ||
| assertEquals("Found list type value for setting [foo.bar] but did not expect a list for it.", e.getMessage()); | ||
| } | ||
|
|
||
| public void testGetAsArrayFailsOnDuplicates() { |
There was a problem hiding this comment.
can we also have a happy path testcase where Setting.listSetting parses successfully ?
|
@amitds1997 Are you still interested in getting this PR in? If so can you please address the comments Przemek made above? |
|
Sorry, I won't be able to get this through. Anyone else can take this up. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings value could be a list. This should only
happen if the underlying setting type is a list setting type.
is also a list setting
value is also a list