-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Service Accounts - Remove colon from invalid token name generator #71099
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,7 @@ public class ServiceAccountTokenTests extends ESTestCase { | |
); | ||
|
||
private static final Set<Character> INVALID_TOKEN_NAME_CHARS = Set.of( | ||
'!', '"', '#', '$', '%', '&', '\'', '(', ')', '*', '+', ',', '.', '/', ':', ';', '<', '=', '>', '?', '@', '[', | ||
'!', '"', '#', '$', '%', '&', '\'', '(', ')', '*', '+', ',', '.', '/', ';', '<', '=', '>', '?', '@', '[', | ||
'\\', ']', '^', '`', '{', '|', '}', '~', ' ', '\t', '\n', '\r'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would a newline have a similar parsing issue in this test? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, I just realised it's not file parsing it's the new token format. So, to answer my question, "No, newline will fail in the expected way". |
||
|
||
public void testIsValidTokenName() { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure we had this method previously but somehow it seemed to be lost in between rebases refactors, rebases and merges.