Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document CCR auto-follow patterns and searchable snapshots indices #70863

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Document CCR auto-follow patterns and searchable snapshots indices #70863

merged 2 commits into from
Apr 6, 2021

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Mar 25, 2021

This pull request adds a note in CCR document about auto-follow patterns that should not match searchable snapshots indices.

Relates #70580 (comment)

@tlrx tlrx added >docs General docs changes :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features v8.0.0 v7.13.0 v7.12.1 labels Mar 25, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Mar 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

henningandersen
henningandersen reviewed Mar 25, 2021
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment.

docs/reference/ccr/auto-follow.asciidoc Outdated
@@ -7,6 +7,12 @@ each new index in the series is replicated automatically. Whenever the name of
a new index on the remote cluster matches the auto-follow pattern, a
corresponding follower index is added to the local cluster.

NOTE: auto-follow patterns creates follower indices only for opened, fully
assigned indices that match the specified pattern in the remote cluster. The
patterns should not match special indices like <<frozen-indices,frozen indices>>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not

I wonder if this is too strict a wording in light of #67686, at least for searchable snapshots, which we will simply just ignore after #70580? Not sure of frozen and read-only though, I suppose we would fail on them (in which case the wording is fine for those).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure of frozen and read-only though, I suppose we would fail on them (in which case the wording is fine for those).

Yes, auto-follow pattern picks up such indices but the follower indices quickly become red as they cannot be initialized (frozen) or cannot read remote index.

Copy link
Member Author

@tlrx tlrx Mar 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that my first try could be more exact. James helped me to find the right wording and I pushed 4811d5c. I removed the mention of frozen indices as they might be removed in the future and they are included in indices that blocks writes anyway.

jrodewig
jrodewig approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question about what fully assigned meant. Otherwise LGTM.

jrodewig
jrodewig approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @tlrx.

@tlrx tlrx merged commit e26e144 into elastic:master Apr 6, 2021
@tlrx tlrx deleted the add-note-auto-follow branch April 6, 2021 08:47
tlrx added a commit to tlrx/elasticsearch that referenced this pull request Apr 6, 2021
@tlrx
Document CCR auto-follow patterns and searchable snapshots indices (e…
2293522 
…lastic#70863)

This commit adds a note in CCR document about auto-follow 
patterns that should not match searchable snapshots indices.

Relates elastic#70580 (comment)
@tlrx tlrx mentioned this pull request Apr 6, 2021
Merged
tlrx added a commit to tlrx/elasticsearch that referenced this pull request Apr 6, 2021
@tlrx
Document CCR auto-follow patterns and searchable snapshots indices (e…
29deb23 
…lastic#70863)

This commit adds a note in CCR document about auto-follow 
patterns that should not match searchable snapshots indices.

Relates elastic#70580 (comment)
@tlrx
Copy link
Member Author

tlrx commented Apr 6, 2021

Thanks James and Henning!

@tlrx tlrx mentioned this pull request Apr 6, 2021
Merged
tlrx added a commit that referenced this pull request Apr 6, 2021
@tlrx
Document CCR auto-follow patterns and searchable snapshots indices (#…
9a1d34c 
…70863) (#71319)

This commit adds a note in CCR document about auto-follow 
patterns that should not match searchable snapshots indices.

Relates #70580 (comment)
tlrx added a commit that referenced this pull request Apr 6, 2021
@tlrx
Document CCR auto-follow patterns and searchable snapshots indices (#…
56bb917 
…70863) (#71320)

This commit adds a note in CCR document about auto-follow 
patterns that should not match searchable snapshots indices.

Relates #70580 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

@henningandersen henningandersen Awaiting requested review from henningandersen

Assignees
No one assigned
Labels
:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v7.12.1 v7.13.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tlrx @elasticmachine @henningandersen @jrodewig @jakelandis