Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork listener#onFailure in PrimaryReplicaSyncer #70506

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Fork listener#onFailure in PrimaryReplicaSyncer #70506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion server/src/main/java/org/elasticsearch/index/shard/PrimaryReplicaSyncer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,24 @@ public void onResponse(ResyncReplicationResponse response) {
@Override
public void onFailure(Exception e) {
if (closed.compareAndSet(false, true)) {
listener.onFailure(e);
executor.execute(new AbstractRunnable() {
@Override
public void onFailure(Exception ex) {
e.addSuppressed(ex);

// We are on the generic threadpool so shouldn't be rejected, and listener#onFailure shouldn't throw anything,
// so getting here should be impossible.
assert false : e;

// Notify the listener on the current thread anyway, just in case.
listener.onFailure(e);
}

@Override
protected void doRun() {
listener.onFailure(e);
}
});
}
}

Expand Down