Allow file read permissions in plugins #69643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds back allowing FilePermission for reading files in plugins. This is a temporary measure until plugins are automatically granted read permissions for files within their own configuration directory. closes elastic#69464
rjernst
added
>bug
:Core/Infra/Plugins
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
added a commit
that referenced
this pull request
Feb 27, 2021
This commit adds back allowing FilePermission for reading files in plugins. This is a temporary measure until plugins are automatically granted read permissions for files within their own configuration directory. closes #69464
rjernst
added a commit
that referenced
this pull request
Feb 27, 2021
This commit adds back allowing FilePermission for reading files in plugins. This is a temporary measure until plugins are automatically granted read permissions for files within their own configuration directory. closes #69464
rjernst
added a commit
that referenced
this pull request
Feb 27, 2021
This commit adds back allowing FilePermission for reading files in plugins. This is a temporary measure until plugins are automatically granted read permissions for files within their own configuration directory. closes #69464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilePermissions were restricted from plugins, with the intention of allowing plugins to still read their own configuration directory. While this works for files directly in the directory, it does not allow symlinks to other special files in the system, for example cloud tokens that exist on their own outside of Elasticsearch.
This commit adds back allowing FilePermission for reading files in plugins. This is a temporary measure until plugins are automatically granted read permissions for files within their own configuration directory.
closes #69464