Some Enhancements to ActionListener (#69103) #69409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds best effort `toString` rendering the various wrapping action listeners to make `TRACE` logging, that will currently only print the top level listener `toString` which isn't helpful to find the original of a listener in case of wrapped listeners, more useful (e.g. when logging rejected executions). Also this change makes the `delegateX` methods less verbose to use and makes use of them in a few spots where they weren't yet used.
original-brownbear
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds best effort
toStringrendering the various wrappingaction listeners to make
TRACElogging, that will currently only print thetop level listener
toStringwhich isn't helpful to find the original of a listenerin case of wrapped listeners, more useful (e.g. when logging rejected executions).
Also this change makes the
delegateXmethods less verbose to use and makes use of themin a few spots where they weren't yet used.
backport of #69103