-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Update monitoring template versions #69317
Conversation
Update monitoring template versions to 7.11.0, to ensure they are replaced on upgrade.
@chrisronline not sure if you can review this or not. If not then I'll try and hunt down someone else who can. |
cc @jakelandis Do we need to bump this version every time we make mapping changes? |
Pinging @elastic/es-core-features (Team:Core/Features) |
@chrisronline - yes @axw - if you are backporting this to 7.12, can you adjust the version here to 7.12 ? It shouldn't make a technical difference, but I can imagine someone looking a support diagnostic and scratching their head why on 7.11 the mappings are not installed. Also maybe a comment in the code that source code was updated in 7.11 but not applied until 7.12 and link to this issue ? |
Thanks @jakelandis, I've updated the version as suggested. |
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@axw - lmk if you bump into any issues merging or backporting. |
* [Monitoring] Update monitoring template versions Update monitoring template versions to 7.11.0, to ensure they are replaced on upgrade. * Change template versions to 7.12.0 Co-authored-by: Elastic Machine <[email protected]>
* [Monitoring] Update monitoring template versions Update monitoring template versions to 7.11.0, to ensure they are replaced on upgrade. * Change template versions to 7.12.0 Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
* [Monitoring] Update monitoring template versions Update monitoring template versions to 7.11.0, to ensure they are replaced on upgrade. * Change template versions to 7.12.0 Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Thanks @jakelandis! All done. |
Update monitoring template versions to 7.12.0, to ensure they are replaced on upgrade.
The "local" (default) monitoring exporter checks the version before replacing the template:
elasticsearch/x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/local/LocalExporter.java
Lines 365 to 377 in 1256558
I made a change to .monitoring_beats in #65997, which landed in 7.11.0, but did not update the template version. On master, the "last updated version" is 7.0.0, and on 7.x it is 7.0.1. There have been several other template changes since 7.0.1. IIANM, with rolling upgrades, monitoring templates would not have been updated since 7.0.1.