[ML] add new delete trained model aliases API #69195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
@elasticmachine update branch |
davidkyle
approved these changes
Feb 18, 2021
| <titleabbrev>Delete Trained Models Aliases</titleabbrev> | ||
| ++++ | ||
|
|
||
| Deletes a trained models alias. |
There was a problem hiding this comment.
Is it "model's" possessive or singular "Deletes a trained model alias"
| @@ -142,7 +142,7 @@ public ClusterState execute(final ClusterState currentState) { | |||
| }); | |||
| } | |||
|
|
|||
| private Set<String> getReferencedModelKeys(IngestMetadata ingestMetadata) { | |||
| static Set<String> getReferencedModelKeys(IngestMetadata ingestMetadata, IngestService ingestService) { | |||
There was a problem hiding this comment.
it is used also in the transport delete trained model alias class to gather all the referenced models to make sure a model alias is not used by a pipeline
…-trained-model-alias
…nwtrent/elasticsearch into feature/ml-delete-trained-model-alias
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Feb 18, 2021
In addition to creating and re-assigning model aliases, users should be able to delete existing and unused model aliases.
benwtrent
added a commit
that referenced
this pull request
Feb 19, 2021
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to creating and re-assigning model aliases, users should be able to delete existing and unused model aliases.