Allow partial indices options in watches #68076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially defined indices options have always been allowed in watches, but the cleanup in elastic#65332 removed this ability and made the definition of indices options within a watch require all fields. This change fixes this by updating the parsing to accept a default indices options and add test coverage for this scenario. Closes elastic#68022
jaymode
added
>bug
:Data Management/Watcher
v8.0.0
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
jaymode
added a commit
to jaymode/elasticsearch
that referenced
this pull request
Jan 28, 2021
Partially defined indices options have always been allowed in watches, but the cleanup in elastic#65332 removed this ability and made the definition of indices options within a watch require all fields. This change fixes this by updating the parsing to accept a default indices options and add test coverage for this scenario. Closes elastic#68022 Backport of elastic#68076
jaymode
added a commit
to jaymode/elasticsearch
that referenced
this pull request
Jan 28, 2021
Partially defined indices options have always been allowed in watches, but the cleanup in elastic#65332 removed this ability and made the definition of indices options within a watch require all fields. This change fixes this by updating the parsing to accept a default indices options and add test coverage for this scenario. Closes elastic#68022 Backport of elastic#68076
This was referenced Jan 28, 2021
jaymode
added a commit
that referenced
this pull request
Jan 28, 2021
Partially defined indices options have always been allowed in watches, but the cleanup in #65332 removed this ability and made the definition of indices options within a watch require all fields. This change fixes this by updating the parsing to accept a default indices options and add test coverage for this scenario. Closes #68022 Backport of #68076
jaymode
added a commit
that referenced
this pull request
Jan 28, 2021
Partially defined indices options have always been allowed in watches, but the cleanup in #65332 removed this ability and made the definition of indices options within a watch require all fields. This change fixes this by updating the parsing to accept a default indices options and add test coverage for this scenario. Closes #68022 Backport of #68076
jaymode
added a commit
that referenced
this pull request
Jan 28, 2021
Partially defined indices options have always been allowed in watches, but the cleanup in #65332 removed this ability and made the definition of indices options within a watch require all fields. This change fixes this by updating the parsing to accept a default indices options and add test coverage for this scenario. Closes #68022 Backport of #68076
jaymode
added a commit
to jaymode/elasticsearch
that referenced
this pull request
Jan 28, 2021
This commit updates the skip versions used in tests that put watches with partial indices options to only skip 7.10.1 and 7.10.2 now that the fix has been backported.
jaymode
added a commit
that referenced
this pull request
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially defined indices options have always been allowed in watches,
but the cleanup in #65332 removed this ability and made the definition
of indices options within a watch require all fields. This change fixes
this by updating the parsing to accept a default indices options and
add test coverage for this scenario.
Closes #68022