Test fix for handshake failure in SSLDriverTests in JDK16 #67337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>test
|
Pinging @elastic/es-security (Team:Security) |
jkakavas
reviewed
Jan 12, 2021
...in/security/src/test/java/org/elasticsearch/xpack/security/transport/nio/SSLDriverTests.java
Outdated
Show resolved
Hide resolved
jkakavas
reviewed
Jan 12, 2021
| final String[] clientProtocols; | ||
| final String expectedMessage; | ||
| if (inFipsJvm()) { | ||
| // fips JSSE does not support TLSv1.3 yet |
There was a problem hiding this comment.
mental note to revisit this when #67233 is fixed, as 1.0.11 includes support for TLS1.3
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Jan 12, 2021
) This fixes the mismatch test between "TLSv1.3" and "TLSv1.2" when running in JDK16 with `-Dtests.fips.enabled=false` and it otherwise maintains the original mismatch test between "TLSv1.1" and "TLSv1.2". Closes elastic#67324
albertzaharovits
added a commit
that referenced
this pull request
Jan 12, 2021
This fixes the mismatch test between "TLSv1.3" and "TLSv1.2" when running in JDK16 with `-Dtests.fips.enabled=false` and it otherwise maintains the original mismatch test between "TLSv1.1" and "TLSv1.2". Closes #67324
This was referenced Jan 15, 2021
albertzaharovits
added a commit
that referenced
this pull request
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSLDriverTests#testHandshakeFailureBecauseProtocolMismatchintentionally uses mismatching TLS protocols between the client and the server in a test scenario. In this particular case, the mismatch is between "TLSv1.1" and "TLSv1.2".The problem is that JDK16 does not support "TLSv1.1" .
This fix tests the mismatch between "TLSv1.3" and "TLSv1.2" when running in JDK16 with
-Dtests.fips.enabled=falseand otherwise maintains the original mismatch test between "TLSv1.1" and "TLSv1.2".Closes #67324