-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping up the version of jackson to 2.12.0 #67214
Conversation
Pinging @elastic/es-core-infra (Team:Core/Infra) |
I believe |
This change has been made @rjernst |
@elasticmachine ok to test |
@jamesrowe08 I've pushed an update to the SHAs that needs to go along with this version bump. Note, however, that it is generally inadvisable to use the |
@elasticmachine update branch |
@elasticmachine update branch |
@elasticmachine update branch |
1 similar comment
@elasticmachine update branch |
There's recent change in Jackson (FasterXML/jackson-dataformat-xml#411) that changed a default behaviour that would prevent upgrading to this version, as it produces an endless loop in the azure sdk code. See |
Thanks for tracking that down @fcofdez. I don't think we can upgrade yet to Jackson 2.12.0 because of this. The Azure SDK still depends on 2.11.3. Unfortunately because Jackson is still a dependency of the Elasticsearch server, any use of it in plugins must match the version provided (otherwise we would get jar hell). While it is a goal to continue to not force these dependencies to match, it likely won't happen before this is simply fixed upstream. In the meantime I am marking this PR as stalled. |
@rjernst If I'm correctly reading the tangle of bugs in that azure issue, I think this is fixed now in the current version 12.11.0 |
This commit upgrades the Azure SDK to 12.11.0 and Jackson to 2.12.2. The Jackson upgrade must happen at the same time due to Azure depending on this new version of Jackson. closes elastic#66555 closes elastic#67214
Thanks @joshbressers. I opened #72833. That requires upgrading Jackson as well in the same commit, so this PR becomes unnecessary. Thanks @jamesrowe08 |
This commit upgrades the Azure SDK to 12.11.0 and Jackson to 2.12.2. The Jackson upgrade must happen at the same time due to Azure depending on this new version of Jackson. closes elastic#66555 closes elastic#67214
This commit upgrades the Azure SDK to 12.11.0 and Jackson to 2.12.2. The Jackson upgrade must happen at the same time due to Azure depending on this new version of Jackson. closes #66555 closes #67214 Co-authored-by: Francisco Fernández Castaño <[email protected]>
This commit upgrades the Azure SDK to 12.11.0 and Jackson to 2.12.2. The Jackson upgrade must happen at the same time due to Azure depending on this new version of Jackson. closes elastic#66555 closes elastic#67214 Co-authored-by: Francisco Fernández Castaño <[email protected]>
This commit upgrades the Azure SDK to 12.11.0 and Jackson to 2.12.2. The Jackson upgrade must happen at the same time due to Azure depending on this new version of Jackson. closes #66555 closes #67214 backport #72995 backport #73011 Co-authored-by: Francisco Fernández Castaño <[email protected]> Co-authored-by: Mark Vieira <[email protected]>
This grabs a new version of jackson and snakeyaml to get some bug fixes. It also updates azure to stay compatible with the new jackson. Closes elastic#66555 Closes elastic#67214 Closes elastic#80142
This grabs a new version of jackson and snakeyaml to get some bug fixes. It also updates azure to stay compatible with the new jackson. Closes elastic#66555 Closes elastic#67214 Closes elastic#80142
This will close #66555
API calls mentioned in that bug now work correctly: