Disable autoscaling capacity test on debian 8 #67159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to java 15, ES running on debian 8 will report 0 memory of host, therefore this test cannot run on debian 8. Relates elastic#67089
henningandersen
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
jasontedor
reviewed
Jan 7, 2021
| public void testCurrentCapacity() throws Exception { | ||
| boolean looksLikeDebian8 = Constants.LINUX && Constants.OS_VERSION.startsWith("3.16.0"); | ||
| final StringTokenizer st = new StringTokenizer(JVM_SPEC_VERSION, "."); |
There was a problem hiding this comment.
We have JavaVersion.CURRENT.compareTo(JavaVersion.parse("15")).
There was a problem hiding this comment.
Thanks, fixed in 2943006
jasontedor
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Oops, I'm really sorry, I didn't mean to leave the Java version comment as a single comment, I had another one for you and I meant to submit them in a batch so you didn't have to react twice, wrong button, 😞. I left that additional comment, up to you either way.
| public void testCurrentCapacity() throws Exception { | ||
| boolean looksLikeDebian8 = Constants.LINUX && Constants.OS_VERSION.startsWith("3.16.0"); |
There was a problem hiding this comment.
I think we can be annoyingly precise here 😇:
diff --git a/x-pack/plugin/autoscaling/src/internalClusterTest/java/org/elasticsearch/xpack/autoscaling/action/TransportGetAutoscalingCapacityActionIT.java b/x-pack/plugin/autoscaling/src/internalClusterTest/java/org/elasticsearch/xpack/autoscaling/action/TransportGetAutoscalingCapacityActionIT.java
index e0ec9b63bff..c75c9fbbc11 100644
--- a/x-pack/plugin/autoscaling/src/internalClusterTest/java/org/elasticsearch/xpack/autoscaling/action/TransportGetAutoscalingCapacityActionIT.java
+++ b/x-pack/plugin/autoscaling/src/internalClusterTest/java/org/elasticsearch/xpack/autoscaling/action/TransportGetAutoscalingCapacityActionIT.java
@@ -6,9 +6,10 @@
package org.elasticsearch.xpack.autoscaling.action;
-import org.apache.lucene.util.Constants;
+import org.elasticsearch.action.admin.cluster.node.info.NodesInfoResponse;
import org.elasticsearch.bootstrap.JavaVersion;
import org.elasticsearch.env.NodeEnvironment;
+import org.elasticsearch.monitor.os.OsInfo;
import org.elasticsearch.monitor.os.OsProbe;
import org.elasticsearch.test.ESIntegTestCase;
import org.elasticsearch.xpack.autoscaling.AutoscalingIntegTestCase;
@@ -26,10 +27,12 @@ import static org.hamcrest.Matchers.greaterThan;
public class TransportGetAutoscalingCapacityActionIT extends AutoscalingIntegTestCase {
public void testCurrentCapacity() throws Exception {
- boolean looksLikeDebian8 = Constants.LINUX && Constants.OS_VERSION.startsWith("3.16.0");
+ final NodesInfoResponse response = client().admin().cluster().prepareNodesInfo().execute().actionGet();
+ final boolean anyDebian8Nodes =
+ response.getNodes().stream().anyMatch(ni -> ni.getInfo(OsInfo.class).getPrettyName().equals("Debian GNU/Linux 8 (jessie)"));
boolean java15Plus = JavaVersion.current().compareTo(JavaVersion.parse("15")) >= 0;
// see: https://github.com/elastic/elasticsearch/issues/67089#issuecomment-756114654
- assumeTrue("cannot run on debian 8 prior to java 15", java15Plus || looksLikeDebian8 == false);
+ assumeTrue("cannot run on debian 8 prior to java 15", java15Plus || anyDebian8Nodes == false);
assertThat(capacity().results().keySet(), Matchers.empty());
long memory = OsProbe.getInstance().getTotalPhysicalMemorySize();There was a problem hiding this comment.
Thanks, precise is good, used your version in 90fad32
henningandersen
added a commit
that referenced
this pull request
Jan 8, 2021
Prior to java 15, ES running on debian 8 will report 0 memory of host, therefore this test cannot run on debian 8. Relates #67089
henningandersen
added a commit
that referenced
this pull request
Jan 8, 2021
Prior to java 15, ES running on debian 8 will report 0 memory of host, therefore this test cannot run on debian 8. Relates #67089
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jan 13, 2021
The selective muting implemented for autoscaling in elastic#67159 is extended to the ML tests that also fail when machine memory is reported as 0. Most of the logic to determine when memory will not be accurately reported is now in a utility method in the base class. Relates elastic#66885 Backport of elastic#67422
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jan 13, 2021
The selective muting implemented for autoscaling in elastic#67159 is extended to the ML tests that also fail when machine memory is reported as 0. Most of the logic to determine when memory will not be accurately reported is now in a utility method in the base class. Relates elastic#66885 Backport of elastic#67422
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jan 13, 2021
The selective muting implemented for autoscaling in elastic#67159 is extended to the ML tests that also fail when machine memory is reported as 0. Most of the logic to determine when memory will not be accurately reported is now in a utility method in the base class. Relates elastic#66885 Backport of elastic#67422
This was referenced Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to java 15, ES running on debian 8 will report 0 memory of host,
therefore this test cannot run on debian 8.
Relates #67089