Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the id field from the InvalidateApiKey API #66671

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Dec 21, 2020

This is a follow-up of #66317 to remove the now deprecated id field from the InvalidateApiKey request.

@ywangd ywangd added >deprecation :Security/Security Security issues without another label v8.0.0 labels Dec 21, 2020
@ywangd ywangd requested a review from tvernum December 21, 2020 01:57
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Dec 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd ywangd merged commit 753e09d into elastic:master Dec 22, 2020
simitt added a commit to simitt/apm-server that referenced this pull request Dec 24, 2020
The ES InvalidateApiKey API does not support param ID anymore. Switch
to using IDs instead. Related elastic/elasticsearch#66671
simitt added a commit to elastic/apm-server that referenced this pull request Dec 24, 2020
The ES InvalidateApiKey API does not support param ID anymore. Switch
to using IDs instead. Related elastic/elasticsearch#66671
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Oct 5, 2021
This PR restore the id field for InvaliateApiKey API so it can be used
if the request explicitly requires v7 compatibility.

Relates: elastic#66671
ywangd added a commit that referenced this pull request Oct 11, 2021
This PR restore the id field for InvaliateApiKey API so it can be used
if the request explicitly requires v7 compatibility.

Relates: #66671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Security/Security Security issues without another label Team:Security Meta label for security team v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants