Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new waiting on shards on index close #66543

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Document new waiting on shards on index close #66543

merged 1 commit into from
Dec 17, 2020

Conversation

DaveCTurner
Copy link
Contributor

In 8.x the default for ?wait_for_active_shards changes from NONE to
DEFAULT on calls to POST /index/_close. This commit adds this change
to the breaking changes docs.

Relates #66419, #66542

@DaveCTurner
Document new waiting on shards on index close
612b7b1 
In 8.x the default for `?wait_for_active_shards` changes from `NONE` to
`DEFAULT` on calls to `POST /index/_close`. This commit adds this change
to the breaking changes docs.

Relates elastic#66419, elastic#66542
@DaveCTurner DaveCTurner added >docs General docs changes :Data Management/Indices APIs APIs to create and manage indices and templates v8.0.0 labels Dec 17, 2020
@DaveCTurner DaveCTurner requested a review from tlrx December 17, 2020 17:01
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Data Management Meta label for data/management team labels Dec 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@DaveCTurner DaveCTurner mentioned this pull request Dec 17, 2020
Closed
@DaveCTurner DaveCTurner merged commit 1c059e7 into elastic:master Dec 17, 2020
@DaveCTurner
Copy link
Contributor Author

Thanks @dakrone

@DaveCTurner DaveCTurner deleted the 2020-12-17-wait_for_active_shards-close-index-breaking-change-docs branch December 17, 2020 17:51
DaveCTurner added a commit that referenced this pull request Dec 17, 2020
@DaveCTurner
Revert "Document new waiting on shards on index close (#66543)"
b622ade 
This reverts commit 1c059e7.
@DaveCTurner
Copy link
Contributor Author

Ugh I just realised that default isn't a legal value for wait_for_active_shards, there's no way today to specify the default. I have reverted this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

@tlrx tlrx Awaiting requested review from tlrx

Assignees
No one assigned
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaveCTurner @elasticmachine @dakrone @jakelandis