EQL: Change result_position default value from head to tail #66387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Something fishy is going on - I get failures with the message "indices.upgrade API does not declare its visibility explicitly in ... [indices.upgrade.json]" which throws the YAML tests off. Raising the PR anyway to see whether the CI catches something else. |
|
Marking this is as a bug since some correctness tests are failing. |
costin
force-pushed
the
eql/desc-by-default
branch
from
d92b2ce to
4daa86e
Compare
|
Incorporated the bug fix in #66493 and updated the PR to get the builds running. |
costin
force-pushed
the
eql/desc-by-default
branch
from
4daa86e to
fd18cc4
Compare
Fix defaults in stats test
costin
force-pushed
the
eql/desc-by-default
branch
from
fd18cc4 to
aec9d8c
Compare
|
@elasticmachine update branch |
costin
added a commit
that referenced
this pull request
Dec 17, 2020
By default, if no pipe is specified, EQL will return return matchings from the tail, end of the stream, not the front. The results are returned in ascending order. (cherry picked from commit 2f50423)
|
Backported to 7.x and 7.11. /cc @jrodewig |
1 task
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Jan 5, 2021
We were previously using what is effectively `results | head` to retrieve the desired amount of results. The default behavior was changed in elastic/elasticsearch#66387, which caused these tests to fail as different results were returned over such a large dataset.
rylnd
added a commit
to elastic/kibana
that referenced
this pull request
Jan 5, 2021
…87254) * Re-enable test skipped due to temporary failure This failure may still be present/intermittent, but it passes reliably locally; trying again on CI to check status. * Triggering build This should fail on the latest snapshot * Update EQL integration tests to reflect new default pipe We were previously using what is effectively `results | head` to retrieve the desired amount of results. The default behavior was changed in elastic/elasticsearch#66387, which caused these tests to fail as different results were returned over such a large dataset. Co-authored-by: Kibana Machine <[email protected]>
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Jan 5, 2021
…lastic#87254) * Re-enable test skipped due to temporary failure This failure may still be present/intermittent, but it passes reliably locally; trying again on CI to check status. * Triggering build This should fail on the latest snapshot * Update EQL integration tests to reflect new default pipe We were previously using what is effectively `results | head` to retrieve the desired amount of results. The default behavior was changed in elastic/elasticsearch#66387, which caused these tests to fail as different results were returned over such a large dataset. Co-authored-by: Kibana Machine <[email protected]>
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Jan 5, 2021
…lastic#87254) * Re-enable test skipped due to temporary failure This failure may still be present/intermittent, but it passes reliably locally; trying again on CI to check status. * Triggering build This should fail on the latest snapshot * Update EQL integration tests to reflect new default pipe We were previously using what is effectively `results | head` to retrieve the desired amount of results. The default behavior was changed in elastic/elasticsearch#66387, which caused these tests to fail as different results were returned over such a large dataset. Co-authored-by: Kibana Machine <[email protected]>
rylnd
added a commit
to elastic/kibana
that referenced
this pull request
Jan 6, 2021
…87254) (#87397) * Re-enable test skipped due to temporary failure This failure may still be present/intermittent, but it passes reliably locally; trying again on CI to check status. * Triggering build This should fail on the latest snapshot * Update EQL integration tests to reflect new default pipe We were previously using what is effectively `results | head` to retrieve the desired amount of results. The default behavior was changed in elastic/elasticsearch#66387, which caused these tests to fail as different results were returned over such a large dataset. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
rylnd
added a commit
to elastic/kibana
that referenced
this pull request
Jan 6, 2021
…87254) (#87396) * Re-enable test skipped due to temporary failure This failure may still be present/intermittent, but it passes reliably locally; trying again on CI to check status. * Triggering build This should fail on the latest snapshot * Update EQL integration tests to reflect new default pipe We were previously using what is effectively `results | head` to retrieve the desired amount of results. The default behavior was changed in elastic/elasticsearch#66387, which caused these tests to fail as different results were returned over such a large dataset. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.