SourceValueFetcher should check all possible source fields #65375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
jtibshirani
approved these changes
Nov 23, 2020
| @@ -635,4 +642,34 @@ public void testCopyFromMultiField() { | |||
| assertThat(e.getMessage(), | |||
| Matchers.containsString("[copy_to] may not be used to copy from a multi-field: [field.bar]")); | |||
| } | |||
|
|
|||
| public void testCopyToValueFetching() throws IOException { | |||
There was a problem hiding this comment.
We could move this to FieldFetcherTests, so all field retrieval tests are in one place. It already has a case around copy_to.
|
@elasticmachine update branch |
romseygeek
added a commit
that referenced
this pull request
Nov 24, 2020
This commit fixes a bug where SourceValueFetcher was returning an empty set of values if any of its source fields were empty; instead, we skip over the empty value and continue collecting from all other source fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where SourceValueFetcher was returning
an empty set of values if any of its source fields were empty; instead,
we skip over the empty value and continue collecting from all other
source fields.