Watcher understands hidden expand wildcard value #65371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watcher has a search template that stores indices options to be used as part of a search during watch execution, but this was not updated to be aware of hidden indices and the `hidden` expand_wildcards option. This change makes use of the `IndicesOptions#toXContent` method in Watcher, which already handles the new value. Additionally, the XContent parsing is moved to the IndicesOptions class so that we will be less likely to miss updating this in the future. Closes elastic#65148 Backport of elastic#65332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watcher has a search template that stores indices options to be used as
part of a search during watch execution, but this was not updated to be
aware of hidden indices and the
hiddenexpand_wildcards option. Thischange makes use of the
IndicesOptions#toXContentmethod in Watcher,which already handles the new value. Additionally, the XContent parsing
is moved to the IndicesOptions class so that we will be less likely to
miss updating this in the future.
Closes #65148
Backport of #65332