Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding API for generating SAML SP metadata #64517

Merged
merged 14 commits into from
Nov 6, 2020
Merged

Adding API for generating SAML SP metadata #64517

merged 14 commits into from
Nov 6, 2020

Conversation

BigPandaToo
Copy link
Contributor

@BigPandaToo BigPandaToo commented Nov 3, 2020 •
edited
Loading

Adding API for generating SAML SP metadata

Resolves #49018

@BigPandaToo BigPandaToo requested a review from jkakavas November 3, 2020 09:25
jkakavas
jkakavas requested changes Nov 3, 2020
View reviewed changes
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments and suggestions

...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSPMetadataAction.java Outdated Show resolved Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSPMetadataAction.java Outdated Show resolved Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSPMetadataAction.java Outdated Show resolved Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSPMetadataAction.java Outdated Show resolved Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/rest/action/saml/RestSamlSPMetadataAction.java Outdated Show resolved Hide resolved
...e/src/main/java/org/elasticsearch/xpack/core/security/action/saml/SamlSPMetadataRequest.java Outdated Show resolved Hide resolved
.../security/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlMetadataCommand.java Outdated Show resolved Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/rest/action/saml/RestSamlSPMetadataAction.java Outdated Show resolved Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/rest/action/saml/RestSamlSPMetadataAction.java Outdated Show resolved Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSPMetadataAction.java Outdated Show resolved Hide resolved
@BigPandaToo
Copy link
Contributor Author

@elasticmachine update branch

@BigPandaToo BigPandaToo requested a review from jkakavas November 3, 2020 22:18
jkakavas
jkakavas requested changes Nov 4, 2020
View reviewed changes
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment on the builder was too vague, I should have mentioned that we can use the SamlSpMetadataBuilder

@BigPandaToo BigPandaToo requested a review from jkakavas November 4, 2020 14:43
@BigPandaToo
Copy link
Contributor Author

@elasticmachine update branch

jkakavas
jkakavas requested changes Nov 4, 2020
View reviewed changes
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @BigPandaToo , just a few final comments, thanks for the iterations!

...ecurity/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlSpMetadataBuilder.java Outdated Show resolved Hide resolved
...ecurity/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlSpMetadataBuilder.java Outdated Show resolved Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/rest/action/saml/RestSamlSpMetadataAction.java Outdated Show resolved Hide resolved
.../security/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlMetadataCommand.java Outdated Show resolved Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSpMetadataAction.java Outdated Show resolved Hide resolved
...re/src/main/java/org/elasticsearch/xpack/core/security/action/saml/SamlSpMetadataAction.java Show resolved Hide resolved
@BigPandaToo BigPandaToo requested a review from jkakavas November 4, 2020 18:14
@BigPandaToo
Copy link
Contributor Author

@elasticmachine update branch

@BigPandaToo
Copy link
Contributor Author

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

expected head sha didn’t match current head ref.

@BigPandaToo
Copy link
Contributor Author

Just submitted the change

jkakavas
jkakavas approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, feel free to merge after addressing those! Thanks @BigPandaToo

...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSpMetadataAction.java Outdated Show resolved Hide resolved
...ecurity/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlSpMetadataBuilder.java Outdated Show resolved Hide resolved
...ecurity/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlSpMetadataBuilder.java Outdated Show resolved Hide resolved
@BigPandaToo BigPandaToo merged commit ad658c6 into elastic:master Nov 6, 2020
BigPandaToo added a commit to BigPandaToo/elasticsearch that referenced this pull request Nov 6, 2020
@BigPandaToo @elasticmachine
Adding API for generating SAML SP metadata (elastic#64517)
324e2c0 
* Adding API for generating SAML SP metadata
Resolve elastic#49018

* Adding API for generating SAML SP metadata
Resolves elastic#49018

* Adding API for generating SAML SP metadata
Resolves elastic#49018

* Adding API for generating SAML SP metadata
Resolves elastic#49018

* Adding API for generating SAML SP metadata
Resolves elastic#49018

* Adding API for generating SAML SP metadata
Resolves elastic#49018

* Adding API for generating SAML SP metadata
Resolves elastic#49018

Co-authored-by: Elastic Machine <[email protected]>
BigPandaToo added a commit that referenced this pull request Nov 6, 2020
@BigPandaToo @elasticmachine
Adding API for generating SAML SP metadata (#64517) (#64731)
c6bfc96 
* Adding API for generating SAML SP metadata
Resolve #49018

* Adding API for generating SAML SP metadata
Resolves #49018

* Adding API for generating SAML SP metadata
Resolves #49018

* Adding API for generating SAML SP metadata
Resolves #49018

* Adding API for generating SAML SP metadata
Resolves #49018

* Adding API for generating SAML SP metadata
Resolves #49018

* Adding API for generating SAML SP metadata
Resolves #49018

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
BigPandaToo added a commit to BigPandaToo/elasticsearch that referenced this pull request Nov 16, 2020
@BigPandaToo
Adding doc for the new API introduced by elastic#64517 - /_security/s…
50cf25a 
…aml/metadata/{realm}

Related to elastic#49018
BigPandaToo added a commit to BigPandaToo/elasticsearch that referenced this pull request Nov 16, 2020
@BigPandaToo
Adding doc for the new API introduced by elastic#64517 - /_security/s…
d3a57fb 
…aml/metadata/{realm}

Related to elastic#49018
@BigPandaToo BigPandaToo mentioned this pull request Nov 16, 2020
Merged
BigPandaToo added a commit to BigPandaToo/elasticsearch that referenced this pull request Nov 16, 2020
@BigPandaToo
Adding doc for the new API introduced by elastic#64517 - /_security/s…
b44b4a9 
…aml/metadata/{realm}

Related to elastic#49018
BigPandaToo added a commit to BigPandaToo/elasticsearch that referenced this pull request Nov 16, 2020
@BigPandaToo
Adding doc for the new API introduced by elastic#64517 - /_security/s…
d9a7e2e 
…aml/metadata/{realm}

Related to elastic#49018
BigPandaToo added a commit to BigPandaToo/elasticsearch that referenced this pull request Nov 16, 2020
@BigPandaToo
Adding doc for the new API introduced by elastic#64517 - /_security/s…
64adf7f 
…aml/metadata/{realm}

Related to elastic#49018
@ywangd ywangd added :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) >enhancement v7.11.0 v8.0.0 labels Nov 17, 2020
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Nov 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

BigPandaToo added a commit to BigPandaToo/elasticsearch that referenced this pull request Nov 17, 2020
@BigPandaToo
Adding doc for the new API introduced by elastic#64517 - /_security/s…
ed189b3 
…aml/metadata/{realm}

Related to elastic#49018
BigPandaToo added a commit that referenced this pull request Nov 17, 2020
@BigPandaToo @lcawl
Adding doc for the new API introduced by #64517 - /_security/saml/met…
0b69d91 
…adata/{realm} (#65065)

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs

Resolves #53161

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

* [DOCS] Adds API to navigation tree

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

Co-authored-by: lcawl <[email protected]>
BigPandaToo added a commit to BigPandaToo/elasticsearch that referenced this pull request Nov 17, 2020
@BigPandaToo @lcawl
Adding doc for the new API introduced by elastic#64517 - /_security/s…
844d2ee 
…aml/metadata/{realm} (elastic#65065)

* Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm}

Related to elastic#49018

* Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm}

Related to elastic#49018

* Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm}

Related to elastic#49018

* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs

Resolves elastic#53161

* Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm}

Related to elastic#49018

* [DOCS] Adds API to navigation tree

* Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm}

Related to elastic#49018

* Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm}

Related to elastic#49018

Co-authored-by: lcawl <[email protected]>
BigPandaToo added a commit that referenced this pull request Nov 17, 2020
@BigPandaToo @lcawl
Adding doc for the new API introduced by #64517 - /_security/saml/met…
fb1d857 
…adata/{realm} (#65065) (#65158)

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm} (#65065)

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs

Resolves #53161

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

* [DOCS] Adds API to navigation tree

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

Co-authored-by: lcawl <[email protected]>

* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs
Resolves #53161

Co-authored-by: lcawl [email protected]
#65065
#backport

* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs
Resolves #53161

Co-authored-by: lcawl [email protected]
#65065
#backport

* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs
Resolves #53161

Co-authored-by: lcawl [email protected]
#65065
#backport

Co-authored-by: lcawl <[email protected]>
BigPandaToo added a commit to BigPandaToo/elasticsearch that referenced this pull request Nov 17, 2020
@BigPandaToo
Adding doc for the new API introduced by elastic#64517 - /_security/s…
7b1b8da 
…aml/metadata/{realm}

Related to elastic#49018
BigPandaToo added a commit that referenced this pull request Dec 4, 2020
@BigPandaToo @elasticmachine
Adding a warning header when a license is about to expire (#64948)
0b586c2 
* This change adds a warning header when a license is about to expire

Resolves #60562

* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs

Resolves #53161

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

* Adding a warning header when a license is about to expire

Resolves #60562

* Addressing the PR feedback

* Switching back to adding the header during featureCheck to allow
warnings when authentication is disabled as well. Adding filterHeader
implementation to SecurityRestFilter exception handling to remove all
the warnings if authentication fails.

* Changing the wording for "expired" message to be consistent with the log
 messages; changing "today" calculation; adding a test case for failing
 authN to make sure we remove the warning header

* Small changes in the way we verify header in tests

* Nit changes

Co-authored-by: Elastic Machine <[email protected]>
BigPandaToo added a commit to BigPandaToo/elasticsearch that referenced this pull request Dec 4, 2020
@BigPandaToo @elasticmachine
Adding a warning header when a license is about to expire (elastic#64948
169c326 
)

* This change adds a warning header when a license is about to expire

Resolves elastic#60562

* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs

Resolves elastic#53161

* Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm}

Related to elastic#49018

* Adding a warning header when a license is about to expire

Resolves elastic#60562

* Addressing the PR feedback

* Switching back to adding the header during featureCheck to allow
warnings when authentication is disabled as well. Adding filterHeader
implementation to SecurityRestFilter exception handling to remove all
the warnings if authentication fails.

* Changing the wording for "expired" message to be consistent with the log
 messages; changing "today" calculation; adding a test case for failing
 authN to make sure we remove the warning header

* Small changes in the way we verify header in tests

* Nit changes

Co-authored-by: Elastic Machine <[email protected]>
BigPandaToo added a commit that referenced this pull request Dec 5, 2020
@BigPandaToo @elasticmachine
Adding a warning header when a license is about to expire #64948 (#65900
e0b75c9 
)

* Adding a warning header when a license is about to expire (#64948)

* This change adds a warning header when a license is about to expire

Resolves #60562

* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs

Resolves #53161

* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}

Related to #49018

* Adding a warning header when a license is about to expire

Resolves #60562

* Addressing the PR feedback

* Switching back to adding the header during featureCheck to allow
warnings when authentication is disabled as well. Adding filterHeader
implementation to SecurityRestFilter exception handling to remove all
the warnings if authentication fails.

* Changing the wording for "expired" message to be consistent with the log
 messages; changing "today" calculation; adding a test case for failing
 authN to make sure we remove the warning header

* Small changes in the way we verify header in tests

* Nit changes

Co-authored-by: Elastic Machine <[email protected]>

* Resolving backporting issue: adding copyMapWithRemovedEntry() util function
Fixing unused imports

Co-authored-by: Elastic Machine <[email protected]>
@stevejgordon stevejgordon mentioned this pull request Dec 17, 2020
Closed
@BigPandaToo BigPandaToo deleted the SAML_SP_API branch April 19, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvernum tvernum tvernum left review comments

@jkakavas jkakavas jkakavas approved these changes

Assignees
No one assigned
Labels
>enhancement :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team v7.11.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SAML API for generating SP metadata
6 participants
@BigPandaToo @elasticmachine @tvernum @jkakavas @jakelandis @ywangd