Add Package Level Javadoc for Snapshot Clones #63217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds package level JavaDoc for snapshot clones. Relates elastic#61839
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
elasticmachine
added
the
Team:Distributed (Obsolete)
| @@ -324,6 +324,8 @@ private static void ensureSnapshotNameNotRunning(List<SnapshotsInProgress.Entry> | |||
| .collect(Collectors.toMap(IndexId::getName, Function.identity())); | |||
| } | |||
|
|
|||
| // TODO: It is worth revisiting the design choice of creating a placeholder entry in snapshots-in-progress here once we have a cache | |||
There was a problem hiding this comment.
Just a thought I had while writing this up. The placeholder logic might be questionable but we can easily remove it in a BwC manner like we did for snapshot create if want to in a follow-up so I'm not too worried here either.
|
Thanks Tanguy! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 5, 2020
Adds package level JavaDoc for snapshot clones. Relates elastic#61839
original-brownbear
added a commit
that referenced
this pull request
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds package level JavaDoc for snapshot clones.
Relates #61839