[ML] adds feature_importance_baseline object to model metadata #63172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
|
@elasticmachine update branch |
…ics-feature-importance-baseline
|
run elasticsearch-ci/2 |
davidkyle
approved these changes
Oct 2, 2020
| private static final String NAME = "feature_importance_class_baseline"; | ||
|
|
||
| public static final ParseField CLASS_NAME = new ParseField("class_name"); | ||
| public static final ParseField BASELINE = new ParseField("baseline"); |
There was a problem hiding this comment.
nit: you could reuse the BASELINE parsefield defined in the parent class
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Oct 5, 2020
…ic#63172) this adds the new field `feature_importance_baseline` and allows it to be optionally be included in the model's metadata. Related to: elastic/ml-cpp#1522
This was referenced Oct 5, 2020
benwtrent
added a commit
that referenced
this pull request
Oct 5, 2020
… (#63237) this adds the new field `feature_importance_baseline` and allows it to be optionally be included in the model's metadata. Related to: elastic/ml-cpp#1522
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds the new field
feature_importance_baselineand allows it to be optionally be included in the model's metadata.