Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make keep alive of point in time optional in search #62184

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Make keep alive of point in time optional in search #62184

merged 3 commits into from
Sep 10, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Sep 9, 2020

A search request should not be required to extend the keep_alive of a point in time. This change makes that parameter optional.

@dnhatn dnhatn added >non-issue :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.10.0 labels Sep 9, 2020
@dnhatn dnhatn requested a review from jimczi September 9, 2020 16:46
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Sep 9, 2020
jimczi
jimczi approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Sep 9, 2020

run elasticsearch-ci/2

@dnhatn
Copy link
Member Author

dnhatn commented Sep 9, 2020

run elasticsearch-ci/packaging-sample-windows

@dnhatn
Copy link
Member Author

dnhatn commented Sep 10, 2020

Thanks Jim!

@dnhatn dnhatn merged commit 8a95e3c into elastic:master Sep 10, 2020
@dnhatn dnhatn deleted the optional-pit-keep-alive branch September 10, 2020 00:07
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Sep 10, 2020
@dnhatn
Make keep alive of point in time optional in search (elastic#62184)
13b7a87 
A search request should not be required to extend the keep_alive of a point in time. 
This change makes that parameter optional.
dnhatn added a commit that referenced this pull request Sep 10, 2020
@dnhatn
Make keep alive of point in time optional in search (#62184)
2eb1e8b 
A search request should not be required to extend the keep_alive of a point in time. 
This change makes that parameter optional.
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Sep 17, 2020
@dnhatn
Adjust keep alive assertion in ShardSearchRequest
c04952a 
Relates elastic#62184
@dnhatn dnhatn mentioned this pull request Sep 17, 2020
Merged
dnhatn added a commit that referenced this pull request Sep 17, 2020
@dnhatn
Adjust keep alive assertion in ShardSearchRequest (#62582)
cc070bf 
Relates #62184
dnhatn added a commit that referenced this pull request Sep 17, 2020
@dnhatn
Adjust keep alive assertion in ShardSearchRequest (#62582)
0127b71 
Relates #62184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimczi jimczi jimczi approved these changes

Assignees
No one assigned
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.10.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnhatn @elasticmachine @jimczi @jakelandis