Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some Outdated BwC Logic #62072

Merged
merged 4 commits into from
Sep 24, 2020
Merged

Remove some Outdated BwC Logic #62072

merged 4 commits into from
Sep 24, 2020

Conversation

original-brownbear
Copy link
Member

Removing some outdated BwC logic from core.

@original-brownbear
Remove some Outdated BwC Logic
7626f74 
Removing some outdated BwC logic from core.
@original-brownbear original-brownbear added >non-issue :Core/Infra/Core Core issues without another label v8.0.0 labels Sep 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Core)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Sep 7, 2020
rjernst
rjernst approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ok, but I started glossing over the changes towards the end. In the future, I think it would be much simpler to review if the changes were grouped by minor version constant.

@original-brownbear
Copy link
Member Author

Thanks Ryan!

@original-brownbear original-brownbear merged commit 225e82f into elastic:master Sep 24, 2020
@original-brownbear original-brownbear deleted the remove-old-bwc-logic branch September 24, 2020 07:20
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Sep 24, 2020
@original-brownbear
Remove Failing and Outdated GeoTile BwC Test
cd00618 
This test is failing randomly since it tests outdated BwC
that was removed in elastic#62072.
@original-brownbear original-brownbear mentioned this pull request Sep 24, 2020
Merged
original-brownbear added a commit that referenced this pull request Sep 24, 2020
@original-brownbear
Remove Failing and Outdated GeoTile BwC Test (#62849)
a183f89 
This test is failing randomly since it tests outdated BwC
that was removed in #62072.
@original-brownbear original-brownbear restored the remove-old-bwc-logic branch December 6, 2020 19:02
@howardhuanghua howardhuanghua mentioned this pull request Mar 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjernst rjernst rjernst approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@original-brownbear @elasticmachine @rjernst @jakelandis