Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add PIT to search after docs #61593

Merged
merged 6 commits into from
Sep 8, 2020
Merged

[DOCS] Add PIT to search after docs #61593

merged 6 commits into from
Sep 8, 2020

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Aug 26, 2020 •
edited
Loading

Updates the Paginate search results page to document search_after + PIT usage.
Also adds admons discouraging use of the scroll APIs.

Closes #61535

Preview

https://elasticsearch_61593.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/paginate-search-results.html

@jrodewig jrodewig marked this pull request as ready for review August 26, 2020 17:34
@jrodewig jrodewig added :Search/Search Search-related issues that do not fall into other categories >docs General docs changes v7.10.0 v8.0.0 labels Aug 26, 2020
@jrodewig jrodewig requested a review from jimczi August 26, 2020 17:34
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Search Meta label for search team labels Aug 26, 2020
@jrodewig jrodewig requested a review from dnhatn August 26, 2020 17:35
jimczi
jimczi reviewed Sep 2, 2020
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments but the update looks great. Thanks for cleaning this part @jrodewig !

docs/reference/search/search-your-data/paginate-search-results.asciidoc Show resolved Hide resolved
docs/reference/search/search-your-data/paginate-search-results.asciidoc Outdated Show resolved Hide resolved
docs/reference/search/search-your-data/paginate-search-results.asciidoc Outdated Show resolved Hide resolved
@jrodewig jrodewig requested a review from jimczi September 3, 2020 13:12
jimczi
jimczi approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit 1b51acb into elastic:master Sep 8, 2020
@jrodewig jrodewig deleted the docs__update-paginate-for-pit branch September 8, 2020 13:53
@jrodewig jrodewig mentioned this pull request Sep 8, 2020
Merged
jrodewig added a commit that referenced this pull request Sep 8, 2020
@jrodewig
Revert "[DOCS] Add PIT to search after docs (#61593)"
c27155c 
This reverts commit 1b51acb.
This was referenced Sep 8, 2020
Closed
Merged
jrodewig added a commit that referenced this pull request Sep 14, 2020
@jrodewig
[7.x] [DOCS] Add PIT to search after docs (#61593) (#62101)
af13c98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimczi jimczi jimczi approved these changes

@dnhatn dnhatn Awaiting requested review from dnhatn

Assignees
No one assigned
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories Team:Docs Meta label for docs team Team:Search Meta label for search team v7.10.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Update Paginate search results for PIT
4 participants
@jrodewig @elasticmachine @jimczi @jakelandis