Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate separation of cryption and signature keys for FIPS #58668

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Jun 29, 2020

Fix an error introduced by merging master into the PR branch which accidentally undone the separation of cryption and signature keys used by FIPS tests.

Resolves: #58651

@ywangd ywangd added >test Issues or PRs that are addressing/adding tests :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC v8.0.0 labels Jun 29, 2020
@ywangd ywangd requested a review from jkakavas June 29, 2020 12:50
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Authorization)

@elasticmachine elasticmachine added the Team:Security Meta label for security team label Jun 29, 2020
Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd ywangd merged commit 14f40c0 into elastic:master Jun 29, 2020
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Jul 1, 2020
…#58668)

Fix an error introduced by merging master into the PR branch which accidentally undone the separation of cryption and signature keys used by FIPS tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] SamlAuthenticatorTests.testSuccessfullyParseContentFromEncryptedAssertion failure
4 participants