Fix exception check in RecoveryRequestTrackerTests #57493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we check that exceptions are the same in the recovery request tracker test. This is inconsistent because the future wraps the exception in a new instance. This commit fixes the test by comparing a random exception message.
…est_tracker_tests
Tim-Brooks
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Recovery) |
elasticmachine
added
the
Team:Distributed (Obsolete)
ywelsch
approved these changes
Jun 2, 2020
Tim-Brooks
added a commit
that referenced
this pull request
Jun 8, 2020
Currently we check that exceptions are the same in the recovery request tracker test. This is inconsistent because the future wraps the exception in a new instance. This commit fixes the test by comparing a random exception message. Fixes #57199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we check that exceptions are the same in the recovery request
tracker test. This is inconsistent because the future wraps the
exception in a new instance. This commit fixes the test by comparing a
random exception message.
Fixes #57199