Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify range query methods for range types. #56976

Merged
merged 1 commit into from
May 20, 2020
Merged

Simplify range query methods for range types. #56976

merged 1 commit into from
May 20, 2020

Conversation

jtibshirani
Copy link
Contributor

For me this is easier to follow. It also avoids parsing the query bounds twice.

@jtibshirani
Simplify range query methods for range types.
ba56fb1 
For me this is easier to follow. It also avoids parsing the query bounds twice.
@jtibshirani jtibshirani added :Search/Search Search-related issues that do not fall into other categories >refactoring v8.0.0 v7.8.1 v7.9.0 labels May 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label May 20, 2020
@jtibshirani jtibshirani mentioned this pull request May 20, 2020
Merged
@jtibshirani jtibshirani requested a review from not-napoleon May 20, 2020 18:26
nik9000
nik9000 approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtibshirani
Copy link
Contributor Author

Thanks for the speedy review.

@jtibshirani jtibshirani merged commit 9a49075 into elastic:master May 20, 2020
@jtibshirani jtibshirani deleted the range-field branch May 20, 2020 18:57
jtibshirani added a commit that referenced this pull request May 20, 2020
@jtibshirani
Simplify range query methods for range types. (#56976)
fb000d6 
For me this is easier to follow. It also avoids parsing the query bounds twice.
jtibshirani added a commit that referenced this pull request May 20, 2020
@jtibshirani
Simplify range query methods for range types. (#56976)
4889e1f 
For me this is easier to follow. It also avoids parsing the query bounds twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

@not-napoleon not-napoleon Awaiting requested review from not-napoleon

Assignees
No one assigned
Labels
>refactoring :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.8.1 v7.9.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtibshirani @elasticmachine @nik9000 @jakelandis