Introduce task heartbeat service #56619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
WIP
:Distributed Coordination/Task Management
|
Pinging @elastic/es-distributed (:Distributed/Task Management) |
elasticmachine
added
the
Team:Distributed (Obsolete)
dnhatn
added a commit
that referenced
this pull request
May 13, 2020
dnhatn
added a commit
that referenced
this pull request
May 14, 2020
|
Integrated in #55779. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I marked this PR as WIP because I think we should cancel orphaned tasks when a channel gets disconnected rather than relying on the heartbeats. The main concern here is the task keepalive interval. If it's too large, then we don't benefit much from the cancellation as the orphaned tasks already consume the resources significantly. And it's very dangerous to lower that interval as we can cancel tasks prematurely. I think we should use the task heartbeat service for cleaning up ban parent markers and releasing search contexts.
Relates #55779