Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the fetch fields phase easier to test. #55756

Merged
merged 2 commits into from
Apr 27, 2020
Merged

Make the fetch fields phase easier to test. #55756

merged 2 commits into from
Apr 27, 2020

Conversation

jtibshirani
Copy link
Contributor

This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.

@jtibshirani
Make the fetch fields phase easier to test.
5adf4f3 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
@jtibshirani jtibshirani added :Search/Search Search-related issues that do not fall into other categories >refactoring labels Apr 24, 2020
@jtibshirani jtibshirani requested a review from nik9000 April 24, 2020 22:26
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@jtibshirani
Copy link
Contributor Author

Inspiration struck just after I merged #55639 :)

nik9000
nik9000 approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@jtibshirani jtibshirani merged this pull request into elastic:field-retrieval Apr 27, 2020
@jtibshirani jtibshirani deleted the fetch-fields-phase branch April 27, 2020 19:43
jtibshirani added a commit that referenced this pull request Apr 27, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
50bdab6 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request Apr 28, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
7e80dbf 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request Apr 29, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
016b3f8 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request May 5, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
4bed910 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request May 7, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
bd48403 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request May 18, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
d4863a4 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request May 20, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
e5b0d15 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request May 28, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
bb11df9 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request May 28, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
d5e2253 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request Jun 8, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
f3c6d33 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request Jun 17, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
9a12417 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request Jun 26, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
d18ce0b 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request Jun 30, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
74a3bf6 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request Jun 30, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
9f7d94e 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request Jul 8, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
4deded0 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request Jul 14, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
adb1ef7 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request Jul 15, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
1ae60b6 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request Jul 18, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
bd623d7 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request Jul 21, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
3c8773b 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit that referenced this pull request Jul 23, 2020
@jtibshirani
Make the fetch fields phase easier to test. (#55756)
b73ec9c 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
jtibshirani added a commit to jtibshirani/elasticsearch that referenced this pull request Jul 27, 2020
@jtibshirani
Make the fetch fields phase easier to test. (elastic#55756)
7145c0b 
This commit pulls out a FieldValueRetriever object, which retrieves specific
fields given a document's source. The new object makes it easier to unit test
the logic, and will help keep FetchFieldsPhase from growing too complex as we
add more functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
>refactoring :Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtibshirani @elasticmachine @nik9000