[ML] Adding failed_category_count to model_size_stats #55716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failed_category_count statistic records the number of times categorization wanted to create a new category but couldn't because the job had reached its model_memory_limit. Relates elastic/ml-cpp#1130
|
Pinging @elastic/ml-core (:ml) |
benwtrent
approved these changes
Apr 24, 2020
lcawl
reviewed
Apr 24, 2020
docs/reference/ml/ml-shared.asciidoc
Outdated
| @@ -603,6 +603,17 @@ If `true`, the output excludes interim results. By default, interim results are | |||
| included. | |||
| end::exclude-interim-results[] | |||
|
|
|||
| tag::failed-category-count[] | |||
| The number of times that categorization wanted to create a new category but | |||
| couldn't because the job had hit its `model_memory_limit`. This number can | |||
There was a problem hiding this comment.
This number can be higher... could be anywhere between 1 and failed-category-count.
Is this a really important detail that folks are likely to be confused about? If not, I think those sentences could be shortened to something like this:
This count does not track which specific categories failed to be created.
If we need to explain why that's important, perhaps another sentence could be added like this: Therefore you cannot use this value to determine the number of unique categories that were missed(?).
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Apr 25, 2020
The failed_category_count statistic records the number of times categorization wanted to create a new category but couldn't because the job had reached its model_memory_limit. Backport of elastic#55716
droberts195
added a commit
that referenced
this pull request
Apr 25, 2020
The failed_category_count statistic records the number of times categorization wanted to create a new category but couldn't because the job had reached its model_memory_limit. Backport of #55716
17 tasks
4 tasks
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 24, 2020
Relates: elastic/elasticsearch#55716, #4803 This commit adds FailedCategoryCount to ModelSizeStats and adds other missing fields to JobStats
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 29, 2020
Relates: elastic/elasticsearch#55716, #4803 This commit adds FailedCategoryCount to ModelSizeStats and adds other missing fields to JobStats
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 29, 2020
Relates: elastic/elasticsearch#55716, #4803 This commit adds FailedCategoryCount to ModelSizeStats and adds other missing fields to JobStats
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 29, 2020
Relates: elastic/elasticsearch#55716, #4803 This commit adds FailedCategoryCount to ModelSizeStats and adds other missing fields to JobStats
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 29, 2020
Relates: elastic/elasticsearch#55716, #4803 This commit adds FailedCategoryCount to ModelSizeStats and adds other missing fields to JobStats Co-authored-by: Russ Cam <[email protected]>
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 30, 2020
Relates: elastic/elasticsearch#55716, #4803 This commit adds FailedCategoryCount to ModelSizeStats and adds other missing fields to JobStats Co-authored-by: Russ Cam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failed_category_count statistic records the number of times
categorization wanted to create a new category but couldn't
because the job had reached its model_memory_limit.
Relates elastic/ml-cpp#1130