Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs fix node_id spec for secure settings reload API #55712

Merged
merged 1 commit into from
May 5, 2020
Merged

Docs fix node_id spec for secure settings reload API #55712

merged 1 commit into from
May 5, 2020

Conversation

chtitux
Copy link
Contributor

@chtitux chtitux commented Apr 24, 2020

node_id is used in all other pages for node selection argument and , add a missing >

I believe this can be backported too :-)

@chtitux
nodes-reload-secure-settings.asciidoc: use node_id
072b4c1 
`node_id` is used in all other pages for node selection argument and , add a missing `>`
@astefan astefan added the :Core/Infra/Settings Settings infrastructure and APIs label Apr 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Settings)

@rjernst rjernst requested review from pgomulka and albertzaharovits and removed request for pgomulka April 27, 2020 18:17
@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@albertzaharovits albertzaharovits added the >docs General docs changes label May 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label May 5, 2020
@albertzaharovits
Copy link
Contributor

@elasticmachine ok to test

@albertzaharovits albertzaharovits added v6.8.10 v7.7.1 v7.8.0 v8.0.0 and removed :Core/Infra/Settings Settings infrastructure and APIs Team:Core/Infra Meta label for core/infra team labels May 5, 2020
@albertzaharovits albertzaharovits changed the title nodes-reload-secure-settings.asciidoc: use node_id Docs fix node_id spec for secure settings reload API May 5, 2020
@albertzaharovits
Copy link
Contributor

Thank you @chtitux for fixing this mistake.

I personally don't like the naming of the node_id parameter because its value is actually a comma-delimited expression of node specifications, but this name is indeed consistent with the documentation from related APIs such as node info and node stats for the same thing, so overall I think this is a good fix.

@albertzaharovits albertzaharovits self-assigned this May 5, 2020
@albertzaharovits albertzaharovits merged commit 0c00a98 into elastic:master May 5, 2020
albertzaharovits pushed a commit that referenced this pull request May 5, 2020
@chtitux @albertzaharovits
Docs fix node_id spec for secure settings reload API (#55712)
8a23da4 
Fix docs typo for the `node_id` parameter in the secure settings reload API.
albertzaharovits pushed a commit that referenced this pull request May 5, 2020
@chtitux @albertzaharovits
Docs fix node_id spec for secure settings reload API (#55712)
5f1787d 
Fix docs typo for the `node_id` parameter in the secure settings reload API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertzaharovits albertzaharovits albertzaharovits approved these changes

Assignees

@albertzaharovits albertzaharovits

Labels
>docs General docs changes Team:Docs Meta label for docs team v7.7.1 v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chtitux @elasticmachine @albertzaharovits @rjernst @astefan @jakelandis