[Rollup] improve stopping tests #55666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synchronized with the test thread in order to test special situations
hendrikmuhs
added
>test
|
Pinging @elastic/es-analytics-geo (:Analytics/Rollup) |
hendrikmuhs
pushed a commit
that referenced
this pull request
Apr 24, 2020
improve tests related to stopping using a client that answers and can be synchronized with the test thread in order to test special situations relates #55011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve tests related to stopping using a client that answers and can be
synchronized with the test thread in order to test special situations
relates #55011
Note
This is a spin off from #55011, which uncovered a weakness of the test: By using a mock client, any request got ignored. This change adds a client that actually answers. As the tests are about state machine testing with 2 parallel threads and unknown timing, it was necessary to synchronize the execution to test certain behavior (stop when state is stopping, start when state is stopping).
The change is necessary because with #55011 the state of the indexer thread is checked in more places. It should fix issues like this.
Sorry, for the noisy PR, the indentation changes are mostly due to using a proper client.
/CC @jimczi