Mute InternalAutoDateHistogramTests.testReduceRandom #54542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fails for 7.6 as well. Do we need backport? |
This'll fail for every branch for the past while. If it is a nuisance then we should. The failure seems to have started December 5th. I have no idea why it hasn't shown up until now. |
|
#45796 is where I bisected this failure to last night. |
|
Which enables the test. So it might go back further. I have no idea. |
|
Ok. You'll love this. It doesn't fail for me now. On any commit. that makes me think it is related to the current time. I'm going to start there! |
|
Ha!!!!!! |
|
@nik9000 I have no idea what the tests were doing. How does the current time affect the test results? Could you please elaborate a bit? Thanks |
|
Check it out! #54602
The short version is that the test data depended on the current time (in
epoch millis) and sometimes it'd hit the bug and sometimes not. The PR I
liked fixes it.
…On Wed, Apr 1, 2020, 20:36 Yang Wang ***@***.***> wrote:
@nik9000 <https://github.com/nik9000> I have no idea what the tests were
doing. How does the current time affect the test results? Could you please
elaborate a bit? Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#54542 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUXIWRTXGWOGFZQ4WRYHDRKPMZRANCNFSM4LYB6XDA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #54540
Relates #39497