Do not fail Evaluate API when the actual and predicted fields' types differ #54255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
evaluate_script_bug
branch
from
c64a809 to
a853e82
Compare
|
Pinging @elastic/ml-core (:ml) |
benwtrent
approved these changes
Mar 26, 2020
...asticsearch/xpack/core/ml/dataframe/evaluation/classification/MulticlassConfusionMatrix.java
Show resolved
Hide resolved
|
run elasticsearch-ci/packaging-sample-matrix-unix |
benwtrent
approved these changes
Mar 26, 2020
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Mar 27, 2020
przemekwitek
added a commit
that referenced
this pull request
Mar 27, 2020
przemekwitek
added a commit
that referenced
this pull request
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Evaluate API fails when the user uses actual and predicted fields of different types (e.g.
longvsboolean) as for some metrics (accuracy, precision)termaggregation tries to parse one type as another.This PR replaces
termaggregation withmatch+lenient: true. This way the Evaluate API does not fail but returns no matches (just as if the sets of actual and predicted classes were disjoint).Additionally, I've took a chance and added a number of new test cases to
ClassificationEvaluationITto increase coverage in case of various actual vs predicted types combinations.Closes #54079