[ML] Get ML filters size should default to 100 #54207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When get filters is called without setting the `size` paramter only up to 10 filters are returned. However, 100 filters should be returned. This commit fixes this and adds an integ test to guard it. It seems this was accidentally broken in elastic#39976. Closes elastic#54206
|
Pinging @elastic/ml-core (:ml) |
benwtrent
approved these changes
Mar 25, 2020
| // nothing to clean | ||
| } | ||
|
|
||
| public void testGetFilters_ShouldReturnUpTo100ByDefault() { |
There was a problem hiding this comment.
#nit
This seems like a very expensive test. Spinning up 3 nodes and native processes to make filter API calls.
I suppose it is thorough. Might could move to our single node internal cluster tests at some point.
There was a problem hiding this comment.
Good point. I fixed it.
dimitris-athanasiou
deleted the
get-ml-filters-size-should-default-to-100
branch
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Mar 26, 2020
When get filters is called without setting the `size` paramter only up to 10 filters are returned. However, 100 filters should be returned. This commit fixes this and adds an integ test to guard it. It seems this was accidentally broken in elastic#39976. Closes elastic#54206 Backport of elastic#54207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When get filters is called without setting the
sizeparameter only up to 10 filters are returned. However,
100 filters should be returned. This commit fixes this
and adds an integ test to guard it.
It seems this was accidentally broken in #39976.
Closes #54206