Fix potential bug in concurrent token refresh support #53668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that we do not proceed execution after calling the listerer's onFailure
jkakavas
added
>bug
:Security/Authentication
|
Pinging @elastic/es-security (:Security/Authentication) |
ywangd
approved these changes
Mar 18, 2020
| @@ -1101,9 +1101,10 @@ void decryptAndReturnSupersedingTokens(String refreshToken, RefreshTokenStatus r | |||
| if (decryptedTokens.length != 2) { | |||
| logger.warn("Decrypted tokens string is not correctly formatted"); | |||
| listener.onFailure(invalidGrantException("could not refresh the requested token")); | |||
| } else { | |||
There was a problem hiding this comment.
This sure works. An alternative is to "return" immediately after "onFailure", which could be safer for future changes, e.g. a new statement is accidentally added below to this if-else block.
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Mar 18, 2020
Ensure that we do not proceed execution after calling the listerer's onFailure
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Mar 18, 2020
Ensure that we do not proceed execution after calling the listerer's onFailure
jkakavas
added a commit
that referenced
this pull request
Mar 18, 2020
jkakavas
added a commit
that referenced
this pull request
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we do not proceed with execution after calling the
listener's onFailure