-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripting, unmapped, supported-type tests to Boxplot #53435
Conversation
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Only thing I'd suggest (maybe in another pr since these are already on the feature branch) is testing the missing
parameter with a field that is mapped, I think all the ones here use an unmapped field
Ooh good catch, didn't notice that. I'll go ahead and add to this PR |
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason I thought these are not needed for this aggregation since we are testing these code paths already in a few others. But I guess I could have messed up handling here. So, good catch!
Yah, it's mostly that we're just dotting i's and crossing t's to make sure the VS refactor, when it merges, doesn't change anything that we didn't expect. So trying to add test parity across all the aggs ahead of time to prevent any surprises :) |
These were added in #53132, but I forgot to merge them to master first 😱
Adds some unit tests for scripting, unmapped fields and "supported types"