SQL: Fix column size for IP data type #53056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set size/displaySize to 45 which is the maximum string for an IP (v6), since IPs are returned as strings. Fixes: elastic#52762
|
Pinging @elastic/es-search (:Search/SQL) |
costin
approved these changes
Mar 3, 2020
| @@ -462,7 +462,7 @@ public static int defaultPrecision(DataType dataType) { | |||
| return 3; | |||
| } | |||
| if (dataType == IP) { | |||
| return 39; | |||
| return 45; | |||
There was a problem hiding this comment.
DataType.size() could be potentially returned since it's the same value.
| @@ -582,7 +582,7 @@ public static int displaySize(DataType dataType) { | |||
| return 29; | |||
| } | |||
| if (dataType == IP) { | |||
There was a problem hiding this comment.
DataType.size() could be potentially returned since it's the same value.
In fact, maybe this approach could be used for other DataTypes as well if applicable - that is whenever size == displaySize
|
No need to backport all the way to 6.x |
matriv
added a commit
that referenced
this pull request
Mar 4, 2020
matriv
added a commit
that referenced
this pull request
Mar 4, 2020
matriv
added a commit
that referenced
this pull request
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set size/displaySize to
45which is the maximum string foran IP (v6), since IPs are returned as strings.
Fixes: #52762