Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Document EQL search REST API #52384

Merged
merged 3 commits into from
Apr 24, 2020
Merged

[DOCS] Document EQL search REST API #52384

merged 3 commits into from
Apr 24, 2020

Conversation

jrodewig
Copy link
Contributor

Add API reference documentation for the EQL search API added with #49768.

For now, this PR only documents parameters expected for use with milestone 1 of #49581. Parameters used for joins are marked as Reserved for future use.

Remaining parameters and response will be documented alongside future development.

@jrodewig jrodewig added >docs General docs changes :Analytics/EQL EQL querying labels Feb 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/EQL)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@jrodewig jrodewig marked this pull request as ready for review February 19, 2020 10:27
@jrodewig
Copy link
Contributor Author

@elasticmachine update branch

2 similar comments
@jrodewig
Copy link
Contributor Author

@elasticmachine update branch

@jrodewig
Copy link
Contributor Author

jrodewig commented Mar 2, 2020

@elasticmachine update branch

@matriv
Copy link
Contributor

matriv commented Mar 30, 2020

@elastic/es-ql

Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left two minor comments.

Comma-separated list of index names or <<indices-aliases,index aliases>> used to
limit the request. Accepts wildcard expressions.
+
To search all indices, use `_all`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it works with * as well: localhost:9200/*/_eql/search

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed this with d09b286. Thanks!

Reserved for future use.

`size`::
(Optional, integer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We say it's integer, but we seem to allow floating point numbers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added float with d09b286. Thanks!

@jrodewig
Copy link
Contributor Author

Thank you @astefan.

@jrodewig jrodewig merged commit 32317a6 into elastic:master Apr 24, 2020
@jrodewig jrodewig deleted the docs__eql-rest-api branch April 24, 2020 18:25
jrodewig added a commit that referenced this pull request Apr 24, 2020
@jrodewig
Copy link
Contributor Author

Backport commits

master 32317a6
7.x c1b0548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/EQL EQL querying >docs General docs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants