Allow _rollup_search with read privilege #52043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywangd
added
>bug
WIP
:Security/Authorization
|
Pinging @elastic/es-security (:Security/Authorization) |
ywangd
commented
Feb 11, 2020
Comment on lines
+17
to
+19
| public void testIndexReadPrivilegeCanPerformRollupSearchAction() { | ||
| assertTrue(Automatons.predicate(IndexPrivilege.READ.getAutomaton()).test(RollupSearchAction.NAME)); | ||
| } |
There was a problem hiding this comment.
Please let me know if there is a better way for this unit test.
|
Repost from slack channel:
|
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Mar 3, 2020
Currently _rollup_search requires manage privilege to access. It should really be a read only operation. This PR changes the requirement to be read indices privilege. Resolves: elastic#50245
ywangd
added a commit
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently _rollup_search requires
manageprivilege to access. It should really be a read only operation. This PR changes the requirement to bereadindices privilege.Resolves: #50245