Percentiles aggregation validation checks for range

[hendrikmuhs]

disallow to specify percentile out of range [0,100]. This also fixes a problem in transform by failing validation if an invalid percentile configuration is used.

Note: The duplication check is a breaking change if you are picky (question is, if it can be found in the wild). -> duplication moved out to PR: TBD

For release notes: Please list it under aggs (percentiles in transforms is a new feature for 7.7.0)

relates to #51808

[elasticmachine]

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

[elasticmachine]

Pinging @elastic/ml-core (:ml/Transform)

[hendrikmuhs]

run elasticsearch-ci/bwc
run elasticsearch-ci/default-distro

[nik9000]

I think this should have an extra space after if and before (.

[nik9000]

Note: The duplication check is a breaking change if you are picky (question is, if it can be found in the wild).

I imagine it can happen, mostly in the case where folks build the percentiles with a tool. What does it look like when there are dups?

I certainly would feel more comfortable making the change in 8.0 only.

[hendrikmuhs]

I imagine it can happen, mostly in the case where folks build the percentiles with a tool. What does it look like when there are dups?

  "aggregations" : {
    "percentile_field" : {
      "values" : {
        "1.0" : 0.0,
        "5.0" : 274.3552087114338,
        "25.0" : 3009.2182284054206,
        "50.0" : 5480.849716847411,
        "50.0" : 5480.849716847411,
        "75.0" : 8015.768454300776,
        "95.0" : 10010.003716690042,
        "99.0" : 17937.91377777778
      }
    }
  }

It depends on the json parser to accept this, it seems common behavior to silently remove the double entry and take the last value.

This issue exists now for a long time without no one noticed or at least not finding it problematic. I therefore agree we can wait for 8.0 to fix it.

I certainly would feel more comfortable making the change in 8.0 only.

I can split the PR:

• the range validation is important for transforms and required for 7.7, this is a non-breaking change.
• for the double percentiles output I added a workaround in [Transform] add support for percentile aggs #51808, so it won't break for transforms, I can move that part into a separate 8.0 only PR

[hendrikmuhs]

I removed the duplication check. I will create a separate PR for this, 8.0 only.
However I require the changes from this PR, so I will do it after this has been merged.

[nik9000]

LGTM