Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Use same index in Cluster Allocation Explain docs #50936

Merged
merged 1 commit into from
Jan 16, 2020
Merged

[DOCS] Use same index in Cluster Allocation Explain docs #50936

merged 1 commit into from
Jan 16, 2020

Conversation

jrodewig
Copy link
Contributor

Updates several example snippets in the Cluster Allocation Explain API docs to consistently use the my_index index.

Previously, the snippets switches from my_index to idx, which could confuse users.

Solves an issue raised by @EmmanuelDemey in #37974.

Updates several example snippets in the Cluster Allocation Explain API
docs to consistently use the `my_index` index.

Previously, the snippets switches from `my_index` to `idx`, which could
confuse users.

Co-authored-by: Emmanuel DEMEY <[email protected]>
@jrodewig jrodewig added >docs General docs changes :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v8.0.0 v7.6.0 v7.5.2 labels Jan 13, 2020
@jrodewig jrodewig requested review from dakrone and tlrx January 13, 2020 19:55
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Allocation)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig
Copy link
Contributor Author

Thanks @dakrone.

@jrodewig jrodewig merged commit ca1a32c into elastic:master Jan 16, 2020
@jrodewig jrodewig deleted the docs__alloc-explain-ex branch January 16, 2020 14:13
jrodewig added a commit that referenced this pull request Jan 16, 2020
Updates several example snippets in the Cluster Allocation Explain API
docs to consistently use the `my_index` index.

Previously, the snippets switches from `my_index` to `idx`, which could
confuse users.

Co-authored-by: Emmanuel DEMEY <[email protected]>

Co-authored-by: Emmanuel DEMEY <[email protected]>
jrodewig added a commit that referenced this pull request Jan 16, 2020
Updates several example snippets in the Cluster Allocation Explain API
docs to consistently use the `my_index` index.

Previously, the snippets switches from `my_index` to `idx`, which could
confuse users.

Co-authored-by: Emmanuel DEMEY <[email protected]>

Co-authored-by: Emmanuel DEMEY <[email protected]>
jrodewig added a commit that referenced this pull request Jan 16, 2020
Updates several example snippets in the Cluster Allocation Explain API
docs to consistently use the `my_index` index.

Previously, the snippets switches from `my_index` to `idx`, which could
confuse users.

Co-authored-by: Emmanuel DEMEY <[email protected]>

Co-authored-by: Emmanuel DEMEY <[email protected]>
@jrodewig
Copy link
Contributor Author

Backport commits

master: ca1a32c
7.x: 1211772
7.6: 6b86b86
7.5: 153470b

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Updates several example snippets in the Cluster Allocation Explain API
docs to consistently use the `my_index` index.

Previously, the snippets switches from `my_index` to `idx`, which could
confuse users.

Co-authored-by: Emmanuel DEMEY <[email protected]>

Co-authored-by: Emmanuel DEMEY <[email protected]>
@polyfractal polyfractal added v7.6.0 and removed v7.6.1 labels Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >docs General docs changes v7.5.2 v7.6.0 v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants