EQL: Replace EqlSearchResponse.Hits parser with ObjectParser #50925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the existing hand-build Hits parser with a ConstructingObjectParser version. Relates to elastic#49581
|
Pinging @elastic/es-search (:Search/EQL) |
imotov
commented
Jan 13, 2020
| while ((token = parser.nextToken()) != XContentParser.Token.END_OBJECT) { | ||
| if (token == XContentParser.Token.FIELD_NAME) { | ||
| currentFieldName = parser.currentName(); | ||
| } else if (token.isValue()) { |
There was a problem hiding this comment.
I didn't implement this path since it existed in the original parser only for backward compatibility with the older version hits total and shouldn't occur in this version.
|
@elasticmachine run elasticsearch-ci/2 |
aleksmaus
pushed a commit
to aleksmaus/elasticsearch
that referenced
this pull request
Jan 27, 2020
…#50925) Replaces the existing hand-build Hits parser with a ConstructingObjectParser version. Relates to elastic#49581
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the existing hand-build Hits parser with a
ConstructingObjectParser version.
Relates to #49581